Started by upstream project "Lucene-MMAPv2-Windows" build number 3,5213521Lucene-MMAPv2-Windowsjob/Lucene-MMAPv2-Windows/1619288a65f5cdc4871d6a4c7ceb1e051acae1010d8b288a65f5cdc4871d6a4c7ceb1e051acae1010d8brefs/remotes/origin/main288a65f5cdc4871d6a4c7ceb1e051acae1010d8b288a65f5cdc4871d6a4c7ceb1e051acae1010d8brefs/remotes/origin/main288a65f5cdc4871d6a4c7ceb1e051acae1010d8b288a65f5cdc4871d6a4c7ceb1e051acae1010d8brefs/remotes/origin/mainhttps://gitbox.apache.org/repos/asf/lucene.git078316861testReportfalseJava: 64bit/hotspot/jdk-25.0.2 -XX:-UseCompressedOops -XX:+UseSerialGC#1619486238652318Lucene-MMAPv2-macOS #16191619falsefalse1619217378SUCCESS1777889988677https://jenkins.thetaphi.de/view/Lucene/job/Lucene-MMAPv2-macOS/1619/macOS VM- lucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollectorManager.javalucene/grouping/src/test/org/apache/lucene/search/grouping/BaseGroupSelectorTestCase.javalucene/CHANGES.txtdc190df0955e0e72e9c862fd4ae6ee992052ec081777879517000https://jenkins.thetaphi.de/user/noreplynoreplynoreply@github.comFix TopGroupsCollectorManager ignoring withinGroupOffset (#15995)
When testing the newly introduced TopGroupsCollectorManager in #15603, found that TopGroupsCollectorManager hardcoded 0 as the withinGroupOffset when calling TopGroups.merge(), causing pagination within groups to be silently ignored, this PR adds withinGroupOffset field and constructor parameter into TopGroupsCollectorManager, also modify the unit test to make it cover non-zero withinGroupOffset case.
In addition, simplify the TopGroupsCollectorManager.reduce() method.
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
2026-05-04 09:25:17 +0200dc190df0955e0e72e9c862fd4ae6ee992052ec08Fix TopGroupsCollectorManager ignoring withinGroupOffset (#15995)editlucene/grouping/src/test/org/apache/lucene/search/grouping/BaseGroupSelectorTestCase.javaeditlucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollectorManager.javaeditlucene/CHANGES.txt
- lucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollectorManager.java288a65f5cdc4871d6a4c7ceb1e051acae1010d8b1777881116000https://jenkins.thetaphi.de/user/javannajavannajavanna@apache.orgRemove leftover from #15995
The collectors arraylist is no longer needed. This commit removes it.
2026-05-04 09:51:56 +0200288a65f5cdc4871d6a4c7ceb1e051acae1010d8bRemove leftover from #15995editlucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollectorManager.java
githttps://jenkins.thetaphi.de/user/noreplynoreplyhttps://jenkins.thetaphi.de/user/javannajavanna