Started by an SCM changeStarted by an SCM changeStarted by an SCM change00818590281859024625934625931.0061926192487fbeed298542dadda6178dba00f7f9e2587031e7cfbeed298542dadda6178dba00f7f9e2587031e7crefs/remotes/origin/branch_10xfbeed298542dadda6178dba00f7f9e2587031e7cfbeed298542dadda6178dba00f7f9e2587031e7crefs/remotes/origin/branch_10xfbeed298542dadda6178dba00f7f9e2587031e7cfbeed298542dadda6178dba00f7f9e2587031e7crefs/remotes/origin/branch_10xhttps://gitbox.apache.org/repos/asf/lucene.gitfalse#487462593455630Lucene ยป Lucene-Maven-Snapshots-10.x #487487falsefalse48712635807SUCCESS1777892372945https://ci-builds.apache.org/job/Lucene/job/Lucene-Maven-Snapshots-10.x/487/lucene-solr-4- lucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollectorManager.javalucene/grouping/src/test/org/apache/lucene/search/grouping/BaseGroupSelectorTestCase.javalucene/CHANGES.txtfbeed298542dadda6178dba00f7f9e2587031e7c1777880792000https://ci-builds.apache.org/user/javannaLuca Cavannajavanna@apache.orgFix TopGroupsCollectorManager ignoring withinGroupOffset (#15995)
When testing the newly introduced TopGroupsCollectorManager in #15603, found that TopGroupsCollectorManager hardcoded 0 as the withinGroupOffset when calling TopGroups.merge(), causing pagination within groups to be silently ignored, this PR adds withinGroupOffset field and constructor parameter into TopGroupsCollectorManager, also modify the unit test to make it cover non-zero withinGroupOffset case.
In addition, simplify the TopGroupsCollectorManager.reduce() method.
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
2026-05-04 09:46:32 +0200fbeed298542dadda6178dba00f7f9e2587031e7cFix TopGroupsCollectorManager ignoring withinGroupOffset (#15995)editlucene/grouping/src/test/org/apache/lucene/search/grouping/BaseGroupSelectorTestCase.javaeditlucene/CHANGES.txteditlucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollectorManager.java
githttps://ci-builds.apache.org/user/javannaLuca Cavanna